WT-334 - Build CMS Components For Advertising Pages - Part 4 #16848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dark-section css files
…ol, and m24 sizing.
…o mozorg/advertising/landing.html
…334-cms-components-for-advertising-sub-navigation
…nto WT-334-cms-components-for-advertising-other-sub-pages
since line breaks are needed on the 'Impact' page
since rich text is needed on the 'Impact' page
…components-for-advertising-subpage
…334-cms-components-for-advertising-sub-navigation
…f github.com:mozilla/bedrock into WT-334-cms-components-for-advertising-sub-navigation
…nto WT-334-cms-components-for-advertising-other-sub-pages
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16848 +/- ##
==========================================
+ Coverage 79.70% 79.97% +0.27%
==========================================
Files 159 161 +2
Lines 8534 8825 +291
==========================================
+ Hits 6802 7058 +256
- Misses 1732 1767 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stevejalim
reviewed
Nov 4, 2025
| - dev | ||
| - test | ||
| - stage | ||
| - prod |
There was a problem hiding this comment.
Heya - were these changes in action.yaml deliberately backed out, or does this branch need a rebase on main?
stevejalim
reviewed
Nov 4, 2025
| env: | ||
| LONG_SHA: ${{ needs.build_and_publish_public_images.outputs.long_sha }} | ||
| DEPLOYMENT_REALM: ${{ needs.build_and_publish_public_images.outputs.deployment_realm }} | ||
| DEPLOYMENT_ENV: ${{ needs.build_and_publish_public_images.outputs.deployment_env }} |
There was a problem hiding this comment.
Same here - I wouldn't expect us to need to back out these changes. Can we rebase / check 'em please?
…334-cms-components-for-advertising-sub-navigation
…nto WT-334-cms-components-for-advertising-other-sub-pages
…components-for-advertising-subpage
…334-cms-components-for-advertising-sub-navigation
…nto WT-334-cms-components-for-advertising-other-sub-pages
dchukhin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.This pull request depends on #16815, which should be reviewed first
One-line summary
This pull request makes the other advertising subpages ('Solutions' and 'Impact') editable through Wagtail.
Significant changes and points to review
Following the work in #16815, this pull request adds:
ContentSubpageas a child ofAdvertisingIndexPageStatisticCalloutBlockandStatisticBlockFeatureListWithModalsBlock,FeatureItemWithModalBlock, andFigureBlockIssue / Bugzilla link
WT-334
Testing
To test locally,