-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare active_users_aggregates for a backfill with shredder mitigation. #6349
base: main
Are you sure you want to change the base?
Prepare active_users_aggregates for a backfill with shredder mitigation. #6349
Conversation
…on. Rename columns [first_seen_date, os_version, segment] to cascade upstream changes during the backfill for stable numbers.
…ith_shredder_mitigation
…n is backfilled. Remove the view generation from the new version which conflicts with previous version.
This comment has been minimized.
This comment has been minimized.
…ith_shredder_mitigation
This comment has been minimized.
This comment has been minimized.
…ith_shredder_mitigation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments that I think are worth addressing, but it's possible that they're not very relevant. If we can address the comments this looks good to go.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ith_shredder_mitigation
…ith_shredder_mitigation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor nits. Looks great though, thanks Lucia!
@@ -7,7 +7,7 @@ WITH todays_metrics AS ( | |||
app_version AS app_version, | |||
normalized_channel AS channel, | |||
IFNULL(country, '??') country, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicky, but for consistency:
IFNULL(country, '??') country, | |
IFNULL(country, '??') AS country, |
@@ -7,7 +7,7 @@ WITH todays_metrics AS ( | |||
app_version AS app_version, | |||
normalized_channel AS channel, | |||
IFNULL(country, '??') country, | |||
city, | |||
IFNULL(city, '??') city, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IFNULL(city, '??') city, | |
IFNULL(city, '??') AS city, |
Integration report for "Merge branch 'main' into DENG-4060_prepare_desktop_aua_for_backfill_with_shredder_mitigation"
|
Description
This PR prepares active_users_aggregates for a backfill with shredder mitigation, which includes renaming columns to cascade upstream changes.
The full backfill from 2018-01-01 until 2024-11-10 is available in
moz-fx-data-shared-prod.backfills_staging_derived.firefox_desktop_derived__active_users_aggregates_v4_2024_11_15
.Related Tickets & Documents
Reviewer, please follow this checklist
┆Issue is synchronized with this Jira Task