-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare active_users_aggregates for a backfill with shredder mitigation. #6349
Open
lucia-vargas-a
wants to merge
14
commits into
main
Choose a base branch
from
DENG-4060_prepare_desktop_aua_for_backfill_with_shredder_mitigation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
10c0ddc
Prepare active_users_aggregates for a backfill with shredder mitigati…
lucia-vargas-a 1120069
Update CODEOWNERS with the new version.
lucia-vargas-a f4889ca
Merge branch 'main' into DENG-4060_prepare_desktop_aua_for_backfill_w…
lucia-vargas-a bc10f22
Avoid modifying the active_users_aggregates view until the new versio…
lucia-vargas-a fef2279
Generate DAG with version.
lucia-vargas-a 623f0d2
Merge branch 'main' into DENG-4060_prepare_desktop_aua_for_backfill_w…
lucia-vargas-a 6b70c53
Adjust schema to query.
lucia-vargas-a 98c3a2a
Merge branch 'main' into DENG-4060_prepare_desktop_aua_for_backfill_w…
lucia-vargas-a 1e40427
Merge branch 'main' into DENG-4060_prepare_desktop_aua_for_backfill_w…
lucia-vargas-a fa6f46b
Ensure attribution columns are present in mobile's schema.
lucia-vargas-a a3eb43e
Merge branch 'main' into DENG-4060_prepare_desktop_aua_for_backfill_w…
lucia-vargas-a 4b4f120
Convert NULLS in city to '??' as required by existing data.
lucia-vargas-a 35e63f0
Merge branch 'main' into DENG-4060_prepare_desktop_aua_for_backfill_w…
lucia-vargas-a 2ea0f66
Merge branch 'main' into DENG-4060_prepare_desktop_aua_for_backfill_w…
lucia-vargas-a File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -7,7 +7,7 @@ WITH todays_metrics AS ( | |||||
app_version AS app_version, | ||||||
normalized_channel AS channel, | ||||||
IFNULL(country, '??') country, | ||||||
city, | ||||||
IFNULL(city, '??') city, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
COALESCE(REGEXP_EXTRACT(locale, r'^(.+?)-'), locale, NULL) AS locale, | ||||||
EXTRACT(YEAR FROM first_seen_date) AS first_seen_year, | ||||||
os, | ||||||
|
@@ -69,4 +69,21 @@ SELECT | |||||
FROM | ||||||
todays_metrics | ||||||
GROUP BY | ||||||
ALL | ||||||
segment, | ||||||
app_name, | ||||||
app_version, | ||||||
channel, | ||||||
country, | ||||||
city, | ||||||
locale, | ||||||
first_seen_year, | ||||||
os, | ||||||
os_version, | ||||||
os_version_major, | ||||||
os_version_minor, | ||||||
submission_date, | ||||||
is_default_browser, | ||||||
distribution_id, | ||||||
attribution_source, | ||||||
attribution_medium, | ||||||
attributed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicky, but for consistency: