fix(sync): Always send firefox.fxaLogout on sign out #18029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZoog
force-pushed
the
session-expired-fix
branch
from
834e88c
to
f4bee1e
Compare
vpomerleau
reviewed
Nov 15, 2024
| return ( | ||
| <div | ||
| className="flex flex-col justify-between min-h-screen" | ||
| data-testid="app" | ||
| > | ||
| <ContentSkip /> | ||
| <div id="body-top" className="hidden mobileLandscape:block" /> | ||
| <HeaderLockup {...{ integration }} /> |
There was a problem hiding this comment.
So nice to not need this prop. 💎
vpomerleau
approved these changes
Nov 15, 2024
|
Confirmed, tested this out locally and it's working as expected! 🏆 |
Because: * If users are signed into the browser but they've accessed account settings in a non-Sync context, the browser holds onto the old session token, leading to a 'Session Expired' page when they try to access CAD or account settings from the browser This commit: * Removes the isSync() check around the firefox.fxaLogout call * Cleans up stuff no longer needed fixes FXA-10770
LZoog
force-pushed
the
session-expired-fix
branch
from
f4bee1e
to
2a4e264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
closes FXA-10770