Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sync): Always send firefox.fxaLogout on sign out #18029

Merged
merged 1 commit into from
Nov 16, 2024
Merged

fix(sync): Always send firefox.fxaLogout on sign out #18029

merged 1 commit into from
Nov 16, 2024

Commits on Nov 15, 2024

  1. fix(sync): Always send firefox.fxaLogout on sign out 

    Because:
* If users are signed into the browser but they've accessed account settings in a non-Sync context, the browser holds onto the old session token, leading to a 'Session Expired' page when they try to access CAD or account settings from the browser

This commit:
* Removes the isSync() check around the firefox.fxaLogout call
* Cleans up stuff no longer needed

fixes FXA-10770
    @LZoog
    LZoog committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2a4e264 View commit details
    Browse the repository at this point in the history