docs(ref): document more of mp_units.core
#662
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
changed the title
math.hmp_units.core
JohelEGP
commented
Dec 28, 2024
Comment on lines
+6323
to
+6324
| % Should this come before the above, like in the C++ standard? | ||
| \rSec4[qty.rand.bern.geo]{Class template \tcode{geometric_distribution}} |
Collaborator
Author
There was a problem hiding this comment.
See the comment.
In the C++ Standard, geometric_distribution comes between
binomial_distribution and negative_binomial_distribution.
Comment on lines
+6472
to
+6483
| \indexlibrarymemberx{extreme_value_distribution}{operator()} | ||
| \begin{itemdecl} | ||
| template<typename Generator> | ||
| Q operator()(Generator& g); | ||
| \end{itemdecl} | ||
| \begin{itemdescr} | ||
| \pnum | ||
| \effects | ||
| Equivalent to: | ||
| \tcode{return Q(base::operator()(g));} | ||
| \end{itemdescr} |
Collaborator
Author
There was a problem hiding this comment.
Can I get rid of these optimizations?
The requirements should be equivalent.
However, I don't see that Q::unit is required to be mp_units::one.
Owner
There was a problem hiding this comment.
One of our contributors provided this code. I did a short review but never had time to analyze all the generators properly. If you see any issues, please do not hesitate to fix them or create a new Issue with the list of things to do.
JohelEGP
commented
Dec 31, 2024
Comment on lines
+1818
to
+1822
| \item | ||
| Otherwise, no effect. | ||
| \begin{note} | ||
| UTF-8 text can't be copied to \tcode{CharT} output. | ||
| \end{note} |
Collaborator
Author
There was a problem hiding this comment.
This should be a constraint (that CharT be either char or char8_t).
JohelEGP
commented
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP (continues #628):
TBDs and still missing:
magnitude-symbol.Representationconcepts.sudo_cast.system_referencemath.hrandom.h