-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Addons - Compute Prefix Sum #32231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cmhhelgeson
wants to merge
6
commits into
mrdoob:dev
Choose a base branch
from
cmhhelgeson:new_prefix_sum
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Addons - Compute Prefix Sum #32231
+1,480
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1745524 to
e16c478
Compare
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
| import { | ||
| StorageInstancedBufferAttribute | ||
| } from 'three'; | ||
| import { Fn, If, instancedArray, invocationLocalIndex, countTrailingZeros, Loop, workgroupArray, subgroupSize, workgroupBarrier, workgroupId, uint, select, invocationSubgroupIndex, dot, uvec4, vec4, float, subgroupAdd, array, subgroupShuffle, subgroupInclusiveAdd, subgroupBroadcast, invocationSubgroupMetaIndex, arrayBuffer, storage } from 'three/tsl'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Unused import arrayBuffer.
work on src use setup approach and register functions that need to be created bitcountNode revert glslNodeBuilder changes lint-fix revert unintended changes to glslNodeBuilder and MathNode, change bitCount helper function names remove extra _include change mainLayout function to accurately reflect WGSL documentation (component wise bitCounts rather than accumulative bitCounts fix nodeType init branch fix prefix sum from other branch eod changes validate reduction, fix display/debug issues fix prefix sum errors fix fix spine scan and work on fixing downsweep add comments work work working prefix sum
ad81371 to
c1909c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31990
Description
Adds a GPGPU Prefix Sum module to the addons for the WebGPURenderer and adjusts some of the syntax in the other GPGPU examples.
In draft till #31990 is complete since it relies heavily on countTrailingZeros and needs to be rebased.