SkyMesh: Add isSkyMesh flag and deprecate isSky#32263
Merged
Mugen87 merged 2 commits intomrdoob:devfrom Nov 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances type checking for the SkyMesh class by introducing a more precise isSkyMesh flag that follows Three.js naming conventions, while deprecating the less specific isSky property for backward compatibility.
- Adds
isSkyMeshflag for precise type testing that matches the class name - Deprecates
isSkyflag with clear JSDoc annotation - Maintains backward compatibility during the transition period
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mugen87
approved these changes
Nov 13, 2025
This was referenced Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new isSkyMesh property for type testing and marked isSky as deprecated.
Looking at the SkyMesh class, here's why we added the
isSkyMeshflag and deprecatedisSky:The class is called
SkyMesh, soisSkyMeshprovides a more precise type check than the genericisSky. This follows the naming convention where the flag matches the class name (Three.js commonly usesis[ClassName]flags for type checking).