Skip to content

Conversation

@querielo
Copy link
Contributor

Added new isSkyMesh property for type testing and marked isSky as deprecated.
Looking at the SkyMesh class, here's why we added the isSkyMesh flag and deprecated isSky:

The class is called SkyMesh, so isSkyMesh provides a more precise type check than the generic isSky. This follows the naming convention where the flag matches the class name (Three.js commonly uses is[ClassName] flags for type checking).

// Before (deprecated)
if (object.isSky) { /* ... */ }

// After (recommended)
if (object.isSkyMesh) { /* ... */ }

Copilot AI review requested due to automatic review settings November 13, 2025 13:04
@querielo querielo changed the title WebGPURenderer: SkyMesh: Add isSkyMesh flag and deprecate isSky SkyMesh: Add isSkyMesh flag and deprecate isSky Nov 13, 2025
Copilot finished reviewing on behalf of querielo November 13, 2025 13:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances type checking for the SkyMesh class by introducing a more precise isSkyMesh flag that follows Three.js naming conventions, while deprecating the less specific isSky property for backward compatibility.

  • Adds isSkyMesh flag for precise type testing that matches the class name
  • Deprecates isSky flag with clear JSDoc annotation
  • Maintains backward compatibility during the transition period

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sunag sunag added this to the r182 milestone Nov 13, 2025
@Mugen87 Mugen87 merged commit 47e7eb7 into mrdoob:dev Nov 13, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants