Skip to content

ci(manual-test): update list of runner images #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

ci(manual-test): update list of runner images #224

merged 1 commit into from
May 2, 2025

Conversation

muzimuzhi
Copy link
Contributor

@muzimuzhi muzimuzhi requested review from mxschmitt and dscho as code owners May 2, 2025 05:16
@dscho
Copy link
Collaborator

dscho commented May 2, 2025

We could also use this opportunity to automate this by writing a tiny node.js script that parses https://github.com/actions/runner-images/blob/HEAD/README.md#available-images and updates the workflow definition.

While at it, how about turning this matrix into a user-defined one, via inputs?

I am thinking of a long list of either boolean inputs (which would then be turned into a matrix array via something like matrix: runs-on: [inputs.ubuntu-22.04 && 'ubuntu-22.04' || '', ...], and would naturally need to exclude the empty runs-on values).

@dscho
Copy link
Collaborator

dscho commented May 2, 2025

I am thinking of a long list of either boolean inputs

I forgot the "or"...

... or a choice list, and then completely do away with the matrix. It's not natural for a human to log into multiple tmate sessions in parallel anyway...

@dscho
Copy link
Collaborator

dscho commented May 2, 2025

@muzimuzhi I'm starting to like the choice option a lot. Wanna give it a try?

@dscho
Copy link
Collaborator

dscho commented May 2, 2025

@mxschmitt Okay, I take your approval as a vote to merge ;-)

@dscho dscho merged commit 9ca996a into mxschmitt:master May 2, 2025
1 check passed
dscho added a commit to dscho/action-tmate that referenced this pull request May 2, 2025
@dscho
Add a node.js script to update manual-test's runs-on options
9ca687b 
As I had suggested in
mxschmitt#224 (comment),
it would be good to have some sort of automation to update the
ever-changing list of runner pools that are supported by GitHub.

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit to dscho/action-tmate that referenced this pull request May 2, 2025
@dscho
Add a node.js script to update manual-test's runs-on options
26050e8 
As I had suggested in
mxschmitt#224 (comment),
it would be good to have some sort of automation to update the
ever-changing list of runner pools that are supported by GitHub.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho mentioned this pull request May 2, 2025
Merged
@muzimuzhi
Copy link
Contributor Author

muzimuzhi commented May 2, 2025 •
edited
Loading

While at it, how about turning this matrix into a user-defined one, via inputs?

@dscho Ah I didn't realize it was a matrix of jobs rather than a choice workflow_dispatch.inputs, until I read your suggestion. Yes a choice input is much more reasonable.

@muzimuzhi muzimuzhi deleted the ci/update-runner-list branch May 2, 2025 22:43
yanksyoon added a commit to canonical/action-tmate that referenced this pull request May 15, 2025
@yanksyoon @vadi2
@dave-gray101 @dscho @chenrui333 @dependabot @lpottier @jeremyd2019 @maschwenk @muzimuzhi
chore: sync upstream (#12)
5aa87dc 
* Don't create /continue on macOS

* add connect-timeout variable

Signed-off-by: Dave Lee <[email protected]>

* run the build

Signed-off-by: Dave Lee <[email protected]>

* action.yml

Signed-off-by: Dave Lee <[email protected]>

* connect-timeout-seconds is a better name

Signed-off-by: Dave Lee <[email protected]>

* chore(deps): bump to use actions/checkout v4 (node20 runtime) (mxschmitt#197)

* chore(deps-dev): bump braces from 3.0.2 to 3.0.3 (mxschmitt#196)

* chore(deps-dev): bump micromatch from 4.0.5 to 4.0.8 (mxschmitt#201)

* Adding support for RHEL-based distributions

Signed-off-by: Loic Pottier <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>

* chore(deps-dev): bump cross-spawn from 7.0.3 to 7.0.5 (mxschmitt#207)

* add new input msys2-location

add new msys2-location input and use instead of hardcoding c:\msys64

* Update README.md with new input

* Update index.js

* use msys2-location input in didTmateQuit and continueFileExists

* Offer `mxschmitt/action-tmate/detached` for convenience

The `mxschmitt/action-tmate/detached` Action does exactly the same as
the `mxschmitt/action-tmate` Action, except defaulting to detached mode.

This will come in handy in the increasingly many cases I seem to
experience of late where I want to use the detached mode without the
price of adding a `with` section.

Not a big price, but it accumulates.

Signed-off-by: Johannes Schindelin <[email protected]>

* README: document the `mxschmitt/action-tmate/detached` Action

This "sub-"Action merely switches the default to `detached: true`. Which
is so much more convenient than having to add a `with:` section _just_
for that mode.

Signed-off-by: Johannes Schindelin <[email protected]>

* ci(manual-detached-test): use the `./detached` "sub-Action"

Signed-off-by: Johannes Schindelin <[email protected]>

* ci(manual-detached-test): drop no-longer-needed setting

We now limit access to the actor by default, iff the actor has a public
SSH key registered in their GitHub profile.

Signed-off-by: Johannes Schindelin <[email protected]>

* ci(manual-test): stop mentioning the obsolete ubuntu-20.04 pool

It has gone to the ~Google~GitHub Graveyard.

Signed-off-by: Johannes Schindelin <[email protected]>

* Add support for output

* Add ssh to output

* (feature) Add outputs to detached action as well

* ci: verify that the `action.yml` files are in sync

In mxschmitt#218, I added a
convenient way to launch this Action in detached mode:
`mxschmitt/action-tmate/detached@v3`.

The way this is implemented is a copy/edited version of `action.yml` in
the `detached/` subdirectory.

This runs the danger of inadvertent divergences, as happened in
mxschmitt#221 (which I caught in
time and the contributor gracefully addressed).

Let's add automation not only to update the file easily but also to
cause a failure in the PR build with a helpful message suggesting how to
fix the problem.

Signed-off-by: Johannes Schindelin <[email protected]>

* detached/action.yml: synchronize with `action.yml`

There was a difference in whitespace, caught by the new step in
`checkin.yml`.

Signed-off-by: Johannes Schindelin <[email protected]>

* ci: fix 'Verify that the project is built'

The output of that step, if something goes wrong, claims that `dist/` is
not up to date, but the build product is in `lib/`.

Also, `git status -s` shows not only differences in the tracked files,
but also untracked files (which should not exist at that stage). Let's
avoid puzzling contributors when there are untracked files by logging
the output of `git status -s`.

Signed-off-by: Johannes Schindelin <[email protected]>

* ci(manual-test): update list of runner images

See https://github.com/actions/runner-images/blob/310e8e963731084df01bcbdbd5044a5ca7fc0c88/README.md#available-images.

* ci(manual-test): convert from a matrix job to a single job

With this change, the `manual-test` workflow accepts user input as to
what runner OS or Docker image to run on.

It is more useful this way, too, as I never encountered a situation
where I would want to run this Action on multiple runners, having to log
in concurrently into multiple tmate sessions, and I doubt that anyone
else has encountered that situation, either.

Signed-off-by: Johannes Schindelin <[email protected]>

* Add a node.js script to update manual-test's `runs-on` options

As I had suggested in
mxschmitt#224 (comment),
it would be good to have some sort of automation to update the
ever-changing list of runner pools that are supported by GitHub.

Signed-off-by: Johannes Schindelin <[email protected]>

* ci(manual-test): update `runs-on` options

Brought to you by the new `update-manual-test.js` script.

Signed-off-by: Johannes Schindelin <[email protected]>

* update-manual-test: special-case Windows/ARM64 runners

For a little more than two weeks, as of time of writing, there are
GitHub-hosted Windows/ARM64 runners (at long last!), announced here:
https://github.blog/changelog/2025-04-14-windows-arm64-hosted-runners-now-available-in-public-preview/

These are not yet listed in the `runner-images` README, therefore we
want to add them manually.

Signed-off-by: Johannes Schindelin <[email protected]>

* manual-test: install MSYS2 on Windows/ARM64

The Windows/ARM64 runners that are currently in public preview do not
have MSYS2 installed by default, so let's do that.

Signed-off-by: Johannes Schindelin <[email protected]>

---------

Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Loic Pottier <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Co-authored-by: Vadim Peretokin <[email protected]>
Co-authored-by: Dave Lee <[email protected]>
Co-authored-by: Johannes Schindelin <[email protected]>
Co-authored-by: Rui Chen <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Loic Pottier <[email protected]>
Co-authored-by: jeremyd2019 <[email protected]>
Co-authored-by: Max schwenk <[email protected]>
Co-authored-by: Yukai Chou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

@dscho dscho Awaiting requested review from dscho dscho is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muzimuzhi @dscho @mxschmitt