Replace comment_char with comment_prefix.#143
Closed
JudoWill wants to merge 1 commit intonanoporetech:masterfrom
Closed
Replace comment_char with comment_prefix.#143JudoWill wants to merge 1 commit intonanoporetech:masterfrom
JudoWill wants to merge 1 commit intonanoporetech:masterfrom
Conversation
FGD-ATR-EP
approved these changes
Sep 2, 2025
fariz020715-bot
approved these changes
Mar 5, 2026
Contributor
|
This was fixed in 0.3.27 - thanks for bringing it to our attention - apologies this has been left open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime between
polarsv0.18 and v0.19 thecomment_charkeyword argument topl.read_csvwas depreciated in favor ofcomment_prefix. This PR replaces the two instances ofcomment_charand should resolve Issue 142.