Version 38

[neffo]

Changes in this version:

• Updated German translation Updated german translation #142 Help translate this extension into your language #14
• Updated Italian translation Updated Italian translation #143 Help translate this extension into your language #14
• Updated Arabic translation Updated and added Arabic translations #146 Help translate this extension into your language #14
• Prevent incomplete images been stored [BUG] partially loaded image is displayed #145
• Is it possible to validate hashes of images [BUG] partially loaded image is displayed #145, this could be done if we got the correct hashes from the JSON (we only get 1080p, not UHD)
• When image folder is moved, the setting appears to revert to default [BUG] Changing download folder doesn't appear to work (again) #106
• Migrate from Soup.SessionAsync (deprecated as of 2.42) [BUG] No settings if GNOME Soup 2.4 isn't available #150
• Better handle home folder relocations [BUG] I changed my home path and BingWallPaper extension goes failed #151
• Some OSes (possibly Ubuntu 22.04 beta) don't expose GLib pictures folder, which can cause strange issues (null in folder names) [BUG] Doesn't set the background image in GNOME 42 #153
• Fix preferences - they look a bit ugly in GTK4, in GNOME 42 the prefs window is slightly too small
• Fix gallery in GNOME 42 - can't scroll, or interact with/close window (currently disabled)
• Set both light and dark style wallpapers in GNOME 42+ [BUG] Doesn't set the background image in GNOME 42 #153
• Bump extension version
• Test on GNOME 3.36.9 (Ubuntu 20.04 LTS)
• Test on GNOME 3.38 (Ubuntu 21.04)
• Test on GNOME 42 (Ubuntu 22.04 beta and GNOME OS)

[bdaase]

I gave this a try on GNOME 42 (to see if it fixes #153), but this doesn't seem to work yet

Mär 14 20:03:20 p14s-gen2-amd gnome-shell[38824]: JS ERROR: TypeError: background is null
                                                   create_background_actor@/home/bjoern/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/overview.js:101:9
                                                   update_backgrounds/<@/home/bjoern/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/overview.js:92:35
                                                   update_backgrounds@/home/bjoern/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/overview.js:91:37
                                                   enable/<@/home/bjoern/.local/share/gnome-shell/extensions/blur-my-shell@aunetx/overview.js:26:18
                                                   destroy@resource:///org/gnome/shell/ui/background.js:721:34
                                                   _updateBackgrounds@resource:///org/gnome/shell/ui/layout.js:499:33
                                                   _prepareStartupAnimation@resource:///org/gnome/shell/ui/layout.js:717:24
                                                   _loadBackground/signalId</id<@resource:///org/gnome/shell/ui/layout.js:655:22

[neffo]

Thanks for testing Bjorn, but those errors seem to be generated by blur-my-shell? Is there a strange interaction occurring here that breaks wallpapers?

[bdaase]

Whoops, sorry, totally messed those up.

I also tested with blur-my-shell disabled now, but the problem persists, the background image isn't set :/

[neffo]

All good, possibly related to the default image folder selection, GNOME 42 (or Glib) seems to do some things differently and I haven't properly tested the new code for handling it.

If you haven't changed anything the defaults may have produced something that doesn't work.

It should be '$HOME/Pictures/BingWallpaper' or equivalent for your locale, but this may get tripped up or may have carried over something from a previous install that has broken.

[bdaase]

All good, possibly related to the default image folder selection, GNOME 40 (or Glib) seems to do some things differently and I haven't properly tested the new code for handling it

Well, but it worked just fine with 41. So it must be something that changed from 41 to 42...

If you haven't changed anything the defaults may have produced something that doesn't work.

Yeah, didn't change anything there.

It should be '$HOME/Pictures/BingWallpaper' or equivalent for your locale, but this may get tripped up or may have carried over something from a previous install that has broken.

It is and the images get saved there just fine. But they don't get set as the background image.

[bdaase]

Alright, I think I know what's happening here now: The images are only set as the “Light” appearance wallpaper, but not as the “Dark” appearance one. That means, the extension currently works just fine if you have set the appearance style in gnome-control-center to “Light” but not when set to “Dark”.

[bdaase]

I gave it a shot now and this fixes it for me

diff --git a/extension.js b/extension.js
index aa20f00..eb14a01 100644
--- a/extension.js
+++ b/extension.js
@@ -55,11 +55,13 @@ function notifyError(msg) {
     Main.notifyError("BingWallpaper extension error", msg);
 }
 
-function doSetBackground(uri, schema) {
+function doSetBackground(uri, schema, set_dark) {
     let gsettings = new Gio.Settings({schema: schema});
     let prev = gsettings.get_string('picture-uri');
     uri = 'file://' + uri;
     gsettings.set_string('picture-uri', uri);
+    if (set_dark)
+        gsettings.set_string('picture-uri-dark', uri);
     Gio.Settings.sync();
     gsettings.apply();
     return (prev != uri); // return true if background uri has changed
@@ -257,11 +259,11 @@ class BingWallpaperIndicator extends PanelMenu.Button {
     }
 
     _setBackgroundDesktop() {
-        doSetBackground(this.filename, Utils.DESKTOP_SCHEMA);
+        doSetBackground(this.filename, Utils.DESKTOP_SCHEMA, true);
     }
     
     _setBackgroundScreensaver() {
-        doSetBackground(this.filename, Utils.LOCKSCREEN_SCHEMA);
+        doSetBackground(this.filename, Utils.LOCKSCREEN_SCHEMA, false);
     }
 
     _copyURLToClipboard() {

[neffo]

Alright, I think I know what's happening here now: The images are only set as the “Light” appearance wallpaper, but not as the “Dark” appearance one. That means, the extension currently works just fine if you have set the appearance style in gnome-control-center to “Light” but when set to “Dark”.

Wasn't aware of this change, might not be exposed in Ubuntu 22.04 beta though (which I am using).

[bdaase]

Wasn't aware of this change, might not be exposed in Ubuntu 22.04 beta though (which I am using).

That might very well be the case, and then the schema key also might not exist in Ubuntu 22.04. The above patch must then probably be guarded in some way...

[neffo]

Ok, implemented a quick fix for this in this branch. Shouldn't break if the key doesn't exist.

UPDATE: appears to correctly set wallpaper on GNOME OS nightly with both light and dark styles

[bdaase]

I can confirm, seems to works as expected.