Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link OpenSSL dynamically #10302

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Link OpenSSL dynamically #10302

merged 1 commit into from
Jan 13, 2025

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jan 7, 2025

Problem

Statically linked OpenSSL is buggy in multithreaded environment:

Summary of changes

Before:

ldd /usr/local/v17/lib/libpq.so
        linux-vdso.so.1 (0x0000ffffb5ce4000)
        libm.so.6 => /lib/aarch64-linux-gnu/libm.so.6 (0x0000ffffb5c10000)
        libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000ffffb5650000)
        /lib/ld-linux-aarch64.so.1 (0x0000ffffb5ca7000)

After:

ldd /usr/local/v17/lib/libpq.so
        linux-vdso.so.1 (0x0000ffffbf3e8000)
        libssl.so.3 => /lib/aarch64-linux-gnu/libssl.so.3 (0x0000ffffbf260000)
        libcrypto.so.3 => /lib/aarch64-linux-gnu/libcrypto.so.3 (0x0000ffffbec00000)
        libm.so.6 => /lib/aarch64-linux-gnu/libm.so.6 (0x0000ffffbf1c0000)
        libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000ffffbea50000)
        /lib/ld-linux-aarch64.so.1 (0x0000ffffbf3ab000)

@bayandin bayandin force-pushed the bayandin/dynamic-openssl branch from 4ff32a1 to 4f58e98 Compare January 7, 2025 19:38
Copy link

github-actions bot commented Jan 7, 2025

7227 tests run: 6873 passed, 0 failed, 354 skipped (full report)


Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 31.2% (8413 of 26961 functions)
  • lines: 48.0% (66780 of 139225 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4f58e98 at 2025-01-07T21:01:27.964Z :recycle:

@bayandin bayandin marked this pull request as ready for review January 9, 2025 15:51
@bayandin bayandin requested review from a team, hlinnaka, MMeent and erikgrinaker and removed request for a team January 13, 2025 12:10
@bayandin bayandin added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit b2d0e1a Jan 13, 2025
90 checks passed
@bayandin bayandin deleted the bayandin/dynamic-openssl branch January 13, 2025 14:13
github-merge-queue bot pushed a commit that referenced this pull request Jan 30, 2025
We don't use statically linked OpenSSL anymore (#10302), 
it's ok to switch to Neon's pgbench for pgvector benchmarks
winter-loo pushed a commit to winter-loo/neon that referenced this pull request Feb 4, 2025
We don't use statically linked OpenSSL anymore (neondatabase#10302), 
it's ok to switch to Neon's pgbench for pgvector benchmarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants