Skip to content

ci: use windows-2025 image #7344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025
Merged

ci: use windows-2025 image #7344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98a24be
ci: use windows-2025 image
mrstork Jun 11, 2025
0d6241b
ci: update windows runner in integration tests
mrstork Jun 11, 2025
dd14a47
ci: update windows runner in unit tests
mrstork Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
timeout-minutes: 20
strategy:
matrix:
os: [windows-latest]
os: [windows-2025]
# Pinning 20.x version as a temporary workaround due to this https://github.com/nodejs/node/issues/52884
node-version: ['20.12.2', '22']
fail-fast: false
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
timeout-minutes: 40
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
os: [ubuntu-latest, macOS-latest, windows-2025]
# Pinning 20.x version as a temporary workaround due to this https://github.com/nodejs/node/issues/52884
node-version: ['20.12.2', '22']
shard: ['1/4', '2/4', '3/4', '4/4']

exclude:
- os: windows-latest
- os: windows-2025
node-version: '22'
fail-fast: false
steps:
Expand All @@ -32,7 +32,7 @@ jobs:
run: |
netsh int ipv4 set dynamicport tcp start=1025 num=64511
REG ADD HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\TCPIP\Parameters /v TcpTimedWaitDelay /t REG_DWORD /d 30 /f
if: "${{ matrix.os == 'windows-latest' }}"
if: "${{ matrix.os == 'windows-2025' }}"

- name: Git checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
# Can be replaced with larger node 23 tests in the future.
integration-win-node-23:
name: Integration test windows latest node23 specific
runs-on: windows-latest
runs-on: windows-2025
timeout-minutes: 40
steps:
# This improves Windows network performance, we need this since we open many ports in our tests
Expand Down Expand Up @@ -172,7 +172,7 @@ jobs:
id: test-coverage-flags
# For windows we have to use $env:
run: |-
os=windows-latest
os=windows-2025
node=$(node --version)
echo "os=${os/-latest/}" >> $GITHUB_OUTPUT
echo "os=${os/-latest/}" >> $env:GITHUB_OUTPUT
Expand All @@ -184,7 +184,7 @@ jobs:
uses: actions/upload-artifact@v4
if: always()
with:
name: npm-logs--windows-latest--23x
name: npm-logs--windows-2025--23x
path: |
~/.npm/_logs/**/*

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
os: [ubuntu-latest, macOS-latest, windows-2025]
node-version: ['20.12.2', '22.x']
exclude:
- os: windows-latest
- os: windows-2025
node-version: '22.x'
fail-fast: false
steps:
Expand Down
Loading