Skip to content

ci: use windows-2025 image #7344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025
Merged

ci: use windows-2025 image #7344

merged 3 commits into from
Jun 12, 2025

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Jun 11, 2025

Summary

Update CI to use the latest windows runner available
Seems to have a positive impact on the flakiness of the e2e tests
Ran a few times without hitting a time out, meanwhile in another branch without this change I'm on attempt 20 in a row


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link

github-actions bot commented Jun 11, 2025

📊 Benchmark results

Comparing with 18ba162

  • Dependency count: 1,128 (no change)
  • Package size: 280 MB (no change)
  • Number of ts-expect-error directives: 399 (no change)

@mrstork
Copy link
Contributor Author

mrstork commented Jun 11, 2025

Prior to merging we would need to change the list of required tests (I do not have permissions to do this)

@mrstork mrstork marked this pull request as ready for review June 11, 2025 23:25
@mrstork mrstork requested a review from a team as a code owner June 11, 2025 23:25
@mrstork mrstork merged commit 0cfa8d2 into main Jun 12, 2025
53 checks passed
@mrstork mrstork deleted the chore/use-windows-2025 branch June 12, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants