Skip to content

NETOBSERV-2221 follow-up: make default metrics, show % ipsec traffic #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

jotak
Copy link
Member

@jotak jotak commented May 28, 2025

Description

Follow-up on #1543
Adding:

  • the added metric is enabled by default (when feature enabled)
  • show the % of encrypted traffic
    • for this, another metric is included, that measures traffic between nodes (excluding inner traffic)

Capture d’écran du 2025-05-28 15-30-57

Dependencies

n/a

@jotak jotak requested a review from OlivierCazade May 28, 2025 14:39
@jotak jotak force-pushed the ipsec-metrics-followup branch from 4ccbc91 to 35400ac Compare May 28, 2025 15:02
@jotak jotak requested a review from jpinsonneau June 3, 2025 13:56
@jotak jotak added the needs-review Tells that the PR needs a review label Jun 3, 2025
Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jotak jotak force-pushed the ipsec-metrics-followup branch from 35400ac to efc4de6 Compare June 3, 2025 15:32
@openshift-ci openshift-ci bot removed the lgtm label Jun 3, 2025
Copy link

openshift-ci bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jun 3, 2025

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator efc4de6 link false /test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2025
@memodi
Copy link
Member

memodi commented Jun 3, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jun 3, 2025
@jotak jotak merged commit a44e9de into netobserv:main Jun 4, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants