-
Notifications
You must be signed in to change notification settings - Fork 19
Set up multi-version docs #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 8 8
Lines 553 553
=======================================
Hits 550 550
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sfmig tests are failing on Python 3.10 because In more detail: I found that in my ethology environment a very old version of How would you suggest proceeding? I would favour going to Pyhton >= 3.11 for |
|
Hi @niksirbi, thanks for this! I usually work with 3.12 and hadn't realised this. Good to know the multi-version docs also serve as a backwards compatibility check for the examples 😅
Yes that would be the best! Since Let me know, thanks again for this! |
|
Hey @sfmig. I will open a separate PR for Python >3.11. We can merge that first, and then rebase this one to |
8c2b1d0 to
760b941
Compare
Description
What is this PR
Why is this PR needed?
To be able to view multiple versions of the docs, including for past versions.
What does this PR do?
deploy_sphinx_docs_multiversionaction instead ofdeploy_sphinx-docsconf.pymovement(which were broken due tomovementalso going multi-version)movementdependency to >=v0.10.0 (the version wheresave_bboxes.to_via_tracks_filewas added).This new setup:
v0.5.1),main(without a tag) to a specialdevfolderdev.latestto the most recent releaseReferences
The 2
movementPRs that this one is based on:Relevant issues/PRs of the actions repo:
MAJOR.MINORversions actions#118How has this PR been tested?
This has been successfully tested on the movement and NeuroBlueprint websites.
To observe the full effects of this change, we need to make a new release after merging this PR, and I recommend doing this soon after merging.
After we are happy with the changes, we can also clean up the old contents of
gh-pages, i.e. delete all root contents other than:index.html.nojekyllCNAMEdevandv{MAJOR}.{MINOR}.{PATCH}.Is this a breaking change?
No.
https://ethology.neuroinformatics.dev will still resolve to the homepage because of the aforementioned aliasing and redirection.
Any links to specific pages, e.g. https://ethology.neuroinformatics.dev/installation.html, will break, as the new links will become https://ethology.neuroinformatics.dev/latest/installation.html. Luckily I found no such links on this repository.
Does this PR require an update to the documentation?
No.
Checklist:
The code has been tested locallyTests have been added to cover all new functionalityThe documentation has been updated to reflect any changes