Skip to content

Conversation

@firewave
Copy link
Contributor

This enables the missinInclude warning to make sure all (local) includes are provided.

@firewave firewave force-pushed the missinclude branch 2 times, most recently from e3c9f82 to 0e402b8 Compare October 31, 2025 16:20
@firewave firewave changed the title enabled missingInclude Cppcheck warnings enabled and fixed missingInclude Cppcheck warnings Oct 31, 2025
@firewave firewave force-pushed the missinclude branch 3 times, most recently from 375ca46 to c7ab9ec Compare October 31, 2025 16:38
@firewave
Copy link
Contributor Author

firewave commented Oct 31, 2025

vrplayer/dlgabout.cpp:2:0: information: Include file: "ui_dlgabout.h" not found. [missingInclude]
#include "ui_dlgabout.h"
^
vrplayer/mainwindow.cpp:2:0: information: Include file: "ui_mainwindow.h" not found. [missingInclude]
#include "ui_mainwindow.h"
^

This requires the files to be generated by Qt.

@firewave
Copy link
Contributor Author

 xrdp/xrdp_process.c:239:46: error: Syntax Error: AST broken, 'self' doesn't have a parent. [internalAstError]
    self->session = libxrdp_init((tbus)self, self->server_trans,
                                             ^

This is caused by a typedef which is only accepted by Visual Studio. I filed https://trac.cppcheck.net/ticket/14245 about it.

@matt335672
Copy link
Member

@firewave - thanks very much for working on this.

Please comment on #3658 if you have the time.

@firewave firewave marked this pull request as ready for review November 4, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants