Code quality: Remove 'struct xrdp_process *' casts #3658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first argument to libxrdp_init() is a intptr_t / tbus value. This represents the xrdp instance which is using the library, but this value is always a 'struct xrdp_process' pointer. This PR replaces the intptr_t with an incomplete type declaration at the interface between xrdp and libxrdp. The original intention was probably to provide some separation from xrdp and the libxrdp code, but in practice this has turned out not to be useful.
firewave
reviewed
Nov 3, 2025
| * Initialise the XRDP library | ||
| * | ||
| * @param id Channel ID (xrdp_process* as integer type) | ||
| * @param proc XRDP instance to use with this library |
There was a problem hiding this comment.
Suggested change
| * @param proc XRDP instance to use with this library | |
| * @param id XRDP instance to use with this library |
The parameter is still called id.
|
LGTM. Using the actual type is much clearer and safer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first argument to
libxrdp_init()is anintptr_t/tbusvalue. This represents the xrdp instance which is using the library, but this value is always astruct xrdp_process *pointer.This PR replaces the
intptr_twith an incomplete type declaration at the interface between xrdp and libxrdp.The original intention was probably to provide some separation from xrdp and the libxrdp code, but in practice this has turned out not to be useful.
This improves readability somewhat in the callbacks, and also unblocks the cppcheck 2.17.1 error in #3657, as cppcheck is no longer confused by the case of
selfto anintptr_t.