-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalization Tab Algorithm #28
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #28 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 236 236
=========================================
Hits 236 236 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't speak to the accuracy of the normalization flow for each instrument but it looks good to the best of my understanding. Documentation builds correctly and looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good and consistent. Note that I did not try to build the doc site locally as I am not setup todo so. Otherwise it looks good.
Description of Changes:
The diagram of the normalization algorithm.
marked in progress
Related Items
To Test:
Documentation - Diagram of the Normalization algorithm
Check list for the pull request
Check list for the reviewer