Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add labels from nri-winservices config as tags on UI. #1989

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: add labels from nri-winservices config as tags on UI. #1989

wants to merge 4 commits into from

Conversation

abhishuraina
Copy link

Add labels from nri-winservices config as tags on the UI.

@abhishuraina abhishuraina requested a review from a team as a code owner January 10, 2025 08:07
@coveralls
Copy link

coveralls commented Jan 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12746199747

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 57.364%
Files with Coverage Reduction New Missed Lines %
pkg/config/config.go 2 70.63%
pkg/integrations/v4/logs/cfg_watcher.go 4 67.5%
Totals Coverage Status
Change from base Build 12746129182: 0.03%
Covered Lines: 15374
Relevant Lines: 26801
💛 - Coveralls

@abhishuraina abhishuraina force-pushed the NR-66527-include-entity-metadata-tags-in-v-4-register-win-services branch from 2185a45 to 642877c Compare January 13, 2025 07:11
@abhishuraina abhishuraina force-pushed the NR-66527-include-entity-metadata-tags-in-v-4-register-win-services branch from 642877c to c8742f8 Compare January 13, 2025 07:31
@abhishuraina abhishuraina force-pushed the NR-66527-include-entity-metadata-tags-in-v-4-register-win-services branch from 98cd97d to 9040635 Compare January 13, 2025 11:24
rubenruizdegauna
rubenruizdegauna approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenruizdegauna rubenruizdegauna rubenruizdegauna approved these changes

@rajrohanyadav rajrohanyadav Awaiting requested review from rajrohanyadav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishuraina @coveralls @rubenruizdegauna @rajrohanyadav