Skip to content

Checkout remote tag if checkout remote branch fails#4247

Merged
pditommaso merged 5 commits intomasterfrom
4246-checkout-new-remote-tag
Nov 10, 2023
Merged

Checkout remote tag if checkout remote branch fails#4247
pditommaso merged 5 commits intomasterfrom
4246-checkout-new-remote-tag

Conversation

@bentsherman
Copy link
Member

Close #4246

checkoutRemoteBranch() now falls back to checking for remote tag if the branch checkout fails (which it will if the revision is a tag).

For some reason though, the returned ref is null, even though a tag is considered a ref, so the message will say "checkout at null: revision [abcdef]". Not sure how to deal with that.

To test:

./launch.sh drop epi2me-labs/wf-basecalling
./launch.sh pull -r v1.0.0 epi2me-labs/wf-basecalling

cd $HOME/.nextflow/assets/epi2me-labs/wf-basecalling
git tag -d v1.0.1
cd -

./launch.sh pull -r v1.0.1 epi2me-labs/wf-basecalling

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 9b8b3d0
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/654e7096113f1400087b5ead

Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to add a unit test?

Signed-off-by: Ben Sherman <[email protected]>
@bentsherman bentsherman added this to the 23.11.0-edge milestone Nov 7, 2023
@pditommaso pditommaso merged commit b8907cc into master Nov 10, 2023
@pditommaso pditommaso deleted the 4246-checkout-new-remote-tag branch November 10, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nextflow pull -r needs to be run twice to pull remote tag

2 participants