Closed
Conversation
Signed-off-by: Edmund Miller <[email protected]>
Signed-off-by: Edmund Miller <[email protected]>
…thod Modify git repository initialization in test to use Git.init() with explicit master branch setting Signed-off-by: Edmund Miller <[email protected]>
…it config scenarios Expand test coverage for Git configuration parsing by adding scenarios for: - Multiple remote URLs - Non-default branch configurations - Custom default branch names Signed-off-by: Edmund Miller <[email protected]>
…module configuration Expand AssetManagerTest with new scenarios: - Handling gitmodules configuration with list and string inputs - Testing manifest file parsing with malformed and missing configurations - Adding submodule operations test - Verifying repository error handling Signed-off-by: Edmund Miller <[email protected]>
Signed-off-by: Edmund Miller <[email protected]>
…ility and structure - Consolidate assertions using 'with' for better clarity. - Update test names for consistency and clarity. - Enhance gitmodules configuration tests to handle both array and string formats. Signed-off-by: Edmund Miller <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
reviewed
Mar 28, 2025
Comment on lines
+342
to
+351
| def 'should create hub provider for #providerName'() { | ||
| when: | ||
| def manager = new AssetManager() | ||
| def repo = manager.createHubProvider('github') | ||
| then: | ||
| repo instanceof GithubRepositoryProvider | ||
|
|
||
| when: | ||
| manager = new AssetManager() | ||
| repo = manager.createHubProvider('bitbucket') | ||
| then: | ||
| repo instanceof BitbucketRepositoryProvider | ||
| def repo = manager.createHubProvider(providerName) | ||
|
|
||
| when: | ||
| manager = new AssetManager() | ||
| repo = manager.createHubProvider('gitlab') | ||
| then: | ||
| repo instanceof GitlabRepositoryProvider | ||
|
|
||
| when: | ||
| manager = [:] as AssetManager | ||
| manager.createHubProvider('xxx') | ||
| then: | ||
| thrown(AbortOperationException) | ||
| repo instanceof RepositoryProvider | ||
|
|
||
| where: | ||
| providerName << ['github', 'bitbucket', 'gitlab'] |
Member
There was a problem hiding this comment.
It's not validating that for a given provider name is creating the expected provider class
pditommaso
force-pushed
the
master
branch
3 times, most recently
from
b4b321e to
069653d
Compare
Member
|
Looks like this pull request lost the momentum. Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An updated attempt and cleaned up from #5711
This is a PR that's pre-work for #4427.
I cleaned up some of the tests in #5610 and @tom-seqera suggested splitting them into separate PRs
I'll follow this up with a PR introducing the features for #4427 after.