Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mask): allow empty mask file, warn not error #1287

Open
wants to merge 1 commit into
base: feat/mask-all-gaps
Choose a base branch
from
Open

feat(mask): allow empty mask file, warn not error #1287

wants to merge 1 commit into from

Commits on Aug 19, 2023

  1. feat(mask): allow empty mask file, warn not error 

    This commit adds a warning message when encountering an empty mask file. Now, instead of throwing an error, a warning is printed with the name of the empty mask file.

Reason: When stubbing out a build, one may want to add an empty mask file
to future proof the repo even if that list of sites is empty

Also: When one just has one masked site, removes it from the file, one generally doesn't want the workflow to error

Config file changes, e.g. removing mask sites, shouldn't cause workflows to error.
This is arguably a bug.
    @corneliusroemer
    corneliusroemer committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    2810abe View commit details
    Browse the repository at this point in the history