Skip to content

Conversation

@corneliusroemer
Copy link
Member

Description of proposed changes

Related issue(s)

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.27%. Comparing base (efabf11) to head (c5e74b3).
Report is 160 commits behind head on master.

Files with missing lines Patch % Lines
augur/ancestral.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1662   +/-   ##
=======================================
  Coverage   72.26%   72.27%           
=======================================
  Files          79       79           
  Lines        8271     8273    +2     
  Branches     1691     1691           
=======================================
+ Hits         5977     5979    +2     
  Misses       2009     2009           
  Partials      285      285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@genehack
Copy link
Contributor

genehack commented Nov 8, 2024

Unsure if updating an error message constitutes a "functional change" that would require a Changelog entry…

@corneliusroemer
Copy link
Member Author

Thanks! It's such a small change, I won't pollute the changelog with it.

@corneliusroemer corneliusroemer merged commit 8731851 into master Nov 9, 2024
29 checks passed
@corneliusroemer corneliusroemer deleted the betterlog branch November 9, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants