-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pandas v2 #1671
Support pandas v2 #1671
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1671 +/- ##
==========================================
+ Coverage 72.29% 72.30% +0.01%
==========================================
Files 79 79
Lines 8276 8276
Branches 1691 1691
==========================================
+ Hits 5983 5984 +1
+ Misses 2008 2007 -1
Partials 285 285 ☔ View full report in Codecov by Sentry. |
b292dba
to
b1dedd8
Compare
I've moved the post-merge checklist to the task list in #1473 |
Not merging this yet so we can release what's on master right now (quite a bit), so we can detect pandas changes in a following release. |
CHANGES.md
Outdated
@@ -4,6 +4,7 @@ | |||
|
|||
### Features | |||
|
|||
* Support pandas v2. [#1671] (@corneliusroemer and @victorlin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to rebase and update the Changelog so it doesn't get out-of-sync due to the latest release of v26.1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or merge via CLI to fix it during the merge as explained in #1620 (comment)
910160b
to
d822fdf
Compare
Support pandas v2.
Pathogen CI uses whatever pandas version is installed by conda base if augur doesn't have conflicting requirements, which is v1 right now, so I made an ephemeral test PR to exclude v2 to test pathogen CI with v2 and it passed, see #1672
Related issue(s)
Resolves #1471
Part of #1473
Checklist