release: Remove condition on event_name #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was flawed: even though ci.yaml is called by another workflow, the `github` context is associated with the caller workflow¹ so event_name is "workflow_dispatch" during a release run. It doesn't make sense to update the condition to match "workflow_dispatch", since there are valid reasons for running ci.yaml using workflow_dispatch. I think it makes more sense to simply remove this half of the condition as redundant². The other half of the condition sufficiently ensures that the job is run only when called by the release workflow on the default branch. ¹ <https://docs.github.com/en/actions/sharing-automations/reusing-workflows> ² <#1634 (comment)>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This was flawed: even though ci.yaml is called by another workflow, the
githubcontext is associated with the caller workflow so event_name is "workflow_dispatch" during a release run.It doesn't make sense to update the condition to match "workflow_dispatch", since there are valid reasons for running ci.yaml using workflow_dispatch.
I think it makes more sense to simply remove this half of the condition as redundant. The other half of the condition sufficiently ensures that the job is run only when called by the release workflow on the default branch.
Related issue(s)
Fixes #1674
Checklist
Automated checks passN/APost-merge: next release happens successfullysee Bug in release workflow: it doesn't actually release anymore #1674 (comment)