-
Notifications
You must be signed in to change notification settings - Fork 136
Support precise date ranges #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1770 +/- ##
=======================================
Coverage 73.63% 73.64%
=======================================
Files 81 81
Lines 8641 8650 +9
Branches 1765 1767 +2
=======================================
+ Hits 6363 6370 +7
- Misses 1976 1977 +1
- Partials 302 303 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9aa117f to
c8b8005
Compare
joverlee521
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. My only suggestion is to clearly document the supported formats for date intervals since that will dictate the outputs for augur curate format-dates in #1494
|
Note: this format is unsupported during subsampling for the same reason as #844: subsampling doesn't use |
|
#1774 should be resolved before this is merged, so that the new format is supported by subsampling in |
ed382a0 to
a27e55d
Compare
a27e55d to
ca464ab
Compare
c0d3f3e to
64c13a6
Compare
This has more flexibility than ambiguous dates in reduced precision which are limited to the range of a single calendar year or month.
ca464ab to
18422e7
Compare
Description of proposed changes
This has more flexibility than ambiguous dates in reduced precision which are limited to the range of a single calendar year or month.
Related issue(s)
Checklist