Skip to content

Improve clarity of deprecation warning for coloring key renames #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+1 −1
Open

Improve clarity of deprecation warning for coloring key renames #1883

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15fbeae
Initial plan
Copilot Sep 7, 2025
5162baf
Improve clarity of coloring deprecation warning message
Copilot Sep 7, 2025
d4db7fd
Remove test for deprecated coloring warning message per user request
Copilot Sep 7, 2025
6fc1921
Update augur/util_support/auspice_config.py
corneliusroemer Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion augur/util_support/auspice_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def _rename_deprecated_colorings(colorings: list):
deprecated(f"[config file] ignoring deprecated {old_key!r} because a coloring for {new_key!r} already exists")
colorings = [c for [idx, c] in enumerate(colorings) if idx!=old_coloring['index']]
else:
deprecated(f"[config file] renaming coloring {old_key!r} to {new_key!r}")
deprecated(f"[config file] The deprecated coloring key {old_key!r} has been automatically renamed to {new_key!r}. Update your auspice config file to use {new_key!r} instead of {old_key!r} to remove this warning.")
colorings[old_coloring['index']]['key'] = new_key
return colorings

Expand Down
Loading