Handle ambiguity in --min-date and --max-date #1914
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Based on #1913
Description of proposed changes
This fixes a bug where incomplete dates such as --max-date 2018 would not be inclusive, since that had previously resolved to --max-date 2018-01-01.
numeric_date() and get_numerical_date_from_value() are two separate functions that serve similar purposes: converting some date value to a numeric date. The latter has had more recent developments, and crucially will return a date range for ambiguous dates. This is desired for min/max date filters, so I've switched to it.
Related issue(s)
Closes #893
Checklist