Add types for read_metadata() and read_csv_with_index_col() #1923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to "Add option to keep index as a column" (537e1fc) where I recently added the function without types. Type for 'filepath_or_buffer' based on pandas-stubs.¹ ¹ https://github.com/pandas-dev/pandas-stubs/blob/64e978cbce28de05ff38105c169387283b6c95c2/pandas-stubs/io/parsers/readers.pyi#L39
This is cleaner and prevents false-positive 'call-overload' Mypy errors.
For type checking.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## victorlin/types #1923 +/- ##
================================================
Coverage 74.18% 74.19%
================================================
Files 82 82
Lines 8996 8997 +1
Branches 1828 1828
================================================
+ Hits 6674 6675 +1
Misses 2018 2018
Partials 304 304 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Based on #1922
Description of proposed changes
For type checking.
Related issue(s)
Follow-up to #1917 (review)
Checklist