Skip to content

Conversation

@jma1991
Copy link

@jma1991 jma1991 commented Feb 14, 2024

This pull request introduces an initial implementation for processing NuGen Ovation RRBS libraries, drawing guidance from the commands outlined in the NuMetRRBS repository. Currently, the focus is on integrating fundamental steps such as adapter trimming and diversity trimming. Although there's an optional component for deduplicating reads via molecular tags, I'm not sure how to implement this right now. Lastly, let me know if I should submit some Ovation data to the test-datasets repository.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jma1991 jma1991 requested a review from a team as a code owner February 14, 2024 14:53
@jma1991 jma1991 requested a review from FelixKrueger February 14, 2024 14:53
Copy link
Contributor

@FelixKrueger FelixKrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested diversity trimming looks good to me, but do we have specific test data for this?

@jma1991
Copy link
Author

jma1991 commented Feb 27, 2024

The suggested diversity trimming looks good to me, but do we have specific test data for this?

I have some Ovation test data, shall I submit it to the test-datasets repository?

@ewels
Copy link
Member

ewels commented Feb 27, 2024

@jma1991 could you please update / rebase this PR off the latest nf-core dev branch please?

@sateeshperi
Copy link
Contributor

@jma1991 checking in here - did you get some test data into the test-datasets repo ?

@sateeshperi sateeshperi added the WIP Work in progress label Sep 23, 2024
@sateeshperi sateeshperi added the stale Will eventually be closed due to divergence and compatibility issues. label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Will eventually be closed due to divergence and compatibility issues. WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants