Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest with nftest #7378

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Pytest with nftest #7378

merged 4 commits into from
Jan 27, 2025

Conversation

SPPearce
Copy link
Contributor

In #7365 @GallVp was converting pytest to nftest for krona/ktimporttaxonomy, but it turns out it already had pytest files.

So I spent some time to check issues with the pytest files and found:

  • Entries in pytest_modules.yml that had no corresponding modules or subworkflow file at all (e.g. gatk4/selectsamples)
  • Entries in pytest_modules.yml that no longer had any pytest files (e.g. angsd/contamination)
  • Modules with pytest and nf-test files, sometimes present in pytest_modules.yml but sometimes not.

In total this removes 18 entries from pytest_modules.yml, plus some more subfolders that weren't listed in there.

@SPPearce SPPearce requested a review from a team as a code owner January 27, 2025 14:23
@GallVp
Copy link
Member

GallVp commented Jan 27, 2025

Thank you @SPPearce

I was about to do something similar and then I saw the email notification for this PR.

@GallVp GallVp added this pull request to the merge queue Jan 27, 2025
Merged via the queue into master with commit 7c21d63 Jan 27, 2025
13 checks passed
@GallVp GallVp deleted the pytest_with_nftest branch January 27, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants