Skip to content

bump mirtop #8257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 14, 2025
Merged

bump mirtop #8257

merged 12 commits into from
Apr 14, 2025

Conversation

lpantano
Copy link
Contributor

@lpantano lpantano commented Apr 9, 2025

PR checklist

related to this: nf-core/smrnaseq#507

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

mashehu
mashehu approved these changes Apr 10, 2025
View reviewed changes
JoseEspinosa
JoseEspinosa previously requested changes Apr 10, 2025
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! But I think the singularity images are missing for those modules, probably this was an error before this version bump, but it would be nice if you could take advantage of this PR to add them

@lpantano lpantano requested a review from JoseEspinosa April 11, 2025 13:36
@maxulysse maxulysse dismissed JoseEspinosa’s stale review April 14, 2025 13:50

changes were addressed

@lpantano lpantano enabled auto-merge April 14, 2025 13:50
@lpantano lpantano added this pull request to the merge queue Apr 14, 2025
Merged via the queue into nf-core:master with commit b0aa8e8 Apr 14, 2025
48 checks passed
@lpantano lpantano deleted the bump_mirtop branch April 14, 2025 13:55
famosab pushed a commit to famosab/modules that referenced this pull request Jun 3, 2025
@lpantano @famosab
bump mirtop (nf-core#8257)
25f8247 
* bump mirtop

* update snaps

* update snap on stats

* update maintainer

* make it in alphanumeric order

* remove extra lines

* add singularity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@mashehu mashehu mashehu approved these changes

@JoseEspinosa JoseEspinosa Awaiting requested review from JoseEspinosa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpantano @maxulysse @mashehu @JoseEspinosa