Rewritten tutorial to write a very simple AWS Lambda #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's an important outstanding question here, and that's this. What do we want to do about SonarCloud, for someone random trying this out? I'm quite keen that this should work out of the box. |
Thanks @regularfry, as discussed, we'll update the SonarCloud onboarding instructions to reflect the current process. Also, please note that the GitHub action that triggers the analysis will not execute if the secrets/variables are not set up. Therefore, the workflow should proceed to the next step not affecting the dev experience. I may make some suggestions on the wording once we have full clarity on the Sonar onboarding process, as this is still WIP. |
stefaniuk
requested changes
Oct 6, 2023
stefaniuk
requested changes
Oct 6, 2023
10 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
<!-- markdownlint-disable-next-line first-line-heading --> ## Description This adds the `make _install-dependencies` task, which installs everything from the `.tool-versions` file. ## Context This avoids the need to add a new `make` task for each dependency, instead treating the `.tool-versions` file as canonical. Specifically it avoids the need for the user to add a `make _install-python` task in [the tutorial](#131). For discussion: do we still need `make _install-terraform` if we have this? I don't think we do. ## Type of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. --> - [ ] Refactoring (non-breaking change) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would change existing functionality) - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I am familiar with the [contributing guidelines](../docs/CONTRIBUTING.md) - [ ] I have followed the code style of the project - [ ] I have added tests to cover my changes - [ ] I have updated the documentation accordingly - [ ] This PR is a result of pair or mob programming --- ## Sensitive Information Declaration To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including [PII (Personal Identifiable Information) / PID (Personal Identifiable Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter. - [ ] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.
The prior tutorial branch involved Docker usage that we don't want to involve as a first contact with the framework. This (minor) rewrite skips the Docker setup, instead leaning on `asdf` for python version management.
The TODO was unnecessary: the SonarCloud step in the build pipeline fails open if it's not configured.
stefaniuk
force-pushed
the
wip-lambda-tutorial
branch
from
8810d85
to
1fa6e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The prior tutorial branch involved Docker usage that we don't want to involve as a first contact with the framework. This (minor) rewrite skips the Docker setup, instead leaning on
asdffor python version management, and a python example that doesn't have any runtimepipdependencies.I have also included a tweak to the markdownlint.yaml config file so that
Makefilequotes and console output are allowed to have tab characters in them.Context
Time to first execution is lower.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.