Feature [RM77] Api Service #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the RickAndMortyService returns a Dictionary from the requested api endpoint
wrumble
reviewed
Aug 11, 2021
Comment on lines
26
to
33
| if let data = data { | ||
| if let jsonResponse = try? JSONSerialization.jsonObject(with: data, options: []) as? Dictionary<String, Any> { | ||
| DispatchQueue.main.async { | ||
| success(jsonResponse) | ||
| } | ||
| } else { | ||
| error(ParseError.invalidJSON) | ||
| } |
There was a problem hiding this comment.
This is a little out of date, idd consider implementing it with the JSONDecoder and using a try-catch instead.
|
|
||
| import Foundation | ||
|
|
||
| final class RickAndMortyService { |
There was a problem hiding this comment.
Why not make this conform to a RickAndMortyServiceProtocol that contains func fetchData(url: URL, success: @escaping (Dictionary<String, Any>) -> (), error: @escaping (Error?) -> ()) that way you are better prepared for dependency injection and testing :)
The RickAndMortyService now decodes for generic types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/novoda/projects/1#card-66572850
The RickAndMortyService provides data from api endpoints.