Feature [RM77] Api Service #78
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| // | ||
| // RickAndMortyService.swift | ||
| // Rick And Morty | ||
| // | ||
| // Created by Scottie Gray on 2021-08-10. | ||
| // Copyright © 2021 Novoda. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| final class RickAndMortyService { | ||
| static let baseURL = URL(string: "https://rickandmortyapi.com/api")! | ||
|
|
||
| enum ParseError: Error { | ||
| case invalidJSON | ||
| } | ||
|
|
||
| func fetchData(url: URL, success: @escaping (Dictionary<String, Any>) -> (), error: @escaping (Error?) -> ()) { | ||
| let request = URLRequest(url: url) | ||
|
|
||
| URLSession.shared.dataTask(with: request) { data, response, requestError in | ||
| if requestError != nil { | ||
| error(requestError) | ||
| } | ||
|
|
||
| if let data = data { | ||
| if let jsonResponse = try? JSONSerialization.jsonObject(with: data, options: []) as? Dictionary<String, Any> { | ||
| DispatchQueue.main.async { | ||
| success(jsonResponse) | ||
| } | ||
| } else { | ||
| error(ParseError.invalidJSON) | ||
| } | ||
|
There was a problem hiding this comment. This is a little out of date, idd consider implementing it with the JSONDecoder and using a try-catch instead. |
||
| } else { | ||
| error(requestError) | ||
| } | ||
| }.resume() | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not make this conform to a
RickAndMortyServiceProtocolthat containsfunc fetchData(url: URL, success: @escaping (Dictionary<String, Any>) -> (), error: @escaping (Error?) -> ())that way you are better prepared for dependency injection and testing :)