Feature [RM79] Character List View Model #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViewModel provides characterCardStates
Changed from get to load considering function does not return anything
Comment on lines
+38
to
+40
| //Image(uiImage: characterCardState.image) | ||
| //.resizable() | ||
| //.aspectRatio(contentMode: .fit) |
There was a problem hiding this comment.
They not to commit commented out code.
Comment on lines
+12
to
+18
| private func getIsAlive(character: Character) -> Bool { | ||
| if character.status == "Alive" { | ||
| return true | ||
| } | ||
|
|
||
| return false | ||
| } |
There was a problem hiding this comment.
If I remember correctly there is also state unknown. is the bool correct choice here?
Comment on lines
+20
to
+26
| private func getFirstEpisode(character: Character) -> String? { | ||
| if let firstEpisode = character.episodeURLs.first { | ||
| return firstEpisode | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
If you're returning nil this code doesn't do anything. you could just call character.episodeURLs.first
|
|
||
| func loadCardStates() { | ||
| characterRepository.getCharacters { characters in | ||
| for character in characters { |
There was a problem hiding this comment.
What do you think about using .map here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/novoda/projects/1#card-66586073
Built a view model which provides card states to the character list view. A card state factory was also built for utility.