Feature [RM79] Character List View Model #82
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // | ||
| // CharacterCardStateFactory.swift | ||
| // Rick And Morty | ||
| // | ||
| // Created by Scottie Gray on 2021-08-13. | ||
| // Copyright © 2021 Novoda. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| final class CharacterCardStateFactory { | ||
| private func getIsAlive(character: Character) -> Bool { | ||
| if character.status == "Alive" { | ||
| return true | ||
| } | ||
|
|
||
| return false | ||
| } | ||
|
|
||
| private func getFirstEpisode(character: Character) -> String? { | ||
| if let firstEpisode = character.episodeURLs.first { | ||
| return firstEpisode | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
Comment on lines
+20
to
+26
There was a problem hiding this comment. If you're returning nil this code doesn't do anything. you could just call |
||
|
|
||
| func createCharacterCardState(from character: Character) -> CharacterCardState { | ||
| let isAlive = getIsAlive(character: character) | ||
| let firstEpisode = getFirstEpisode(character: character) ?? "Unknown" | ||
| let characterCardState = CharacterCardState(id: character.id, name: character.name, imageURL: character.imageURL, isAlive: isAlive, species: character.species, lastLocation: character.lastLocation.name, firstEpisode: firstEpisode) | ||
|
|
||
| return characterCardState | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // | ||
| // CharacterListViewModel.swift | ||
| // Rick And Morty | ||
| // | ||
| // Created by Scottie Gray on 2021-08-13. | ||
| // Copyright © 2021 Novoda. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| final class CharacterListViewModel: ObservableObject { | ||
| @Published var characterListViewState: CharacterListViewState = CharacterListViewState(characterCardStates: []) | ||
|
|
||
| private let characterRepository: CharacterRepositoryProtocol = CharacterRepository() | ||
| private let characterCardStateFactory = CharacterCardStateFactory() | ||
|
|
||
| init() { | ||
| loadCardStates() | ||
| } | ||
|
|
||
| func loadCardStates() { | ||
| characterRepository.getCharacters { characters in | ||
| for character in characters { | ||
|
There was a problem hiding this comment. What do you think about using |
||
| let cardState = self.characterCardStateFactory.createCharacterCardState(from: character) | ||
| self.characterListViewState.characterCardStates.append(cardState) | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly there is also state
unknown. is the bool correct choice here?