samples: bluetooth: added throughput many_to_one sample #26038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NordicBuilder
added
doc-required
nordicjm
requested changes
Dec 8, 2025
| @@ -0,0 +1,5 @@ | |||
| # Copyright (c) 2025 Nordic Semiconductor ASA | |||
Contributor
There was a problem hiding this comment.
fix commit message by splitting into multiple lines (70 char max per line)
| bool "Throughput many-to-one Sample Settings" | ||
| default y | ||
| help | ||
| Enable configuration options for throughput many-to-one sample using PAwR |
Comment on lines
4
to
6
| source "Kconfig.zephyr" | ||
|
|
||
| rsource "periodic_adv_rsp/Kconfig" |
Contributor
There was a problem hiding this comment.
the bottom does an include of Kconfig.zephyr
Comment on lines
12
to
13
| # Enable floating point printf | ||
| target_compile_definitions(app PRIVATE CONFIG_CBPRINTF_FP_SUPPORT=y) |
Contributor
There was a problem hiding this comment.
what are you doing? use a prj.conf file
| #define MSD_HEADER_LEN 4 /* Manufacturer specific data header length */ | ||
| #define ACK_ENTRY_SIZE 5 /* token (4B) + slot (1B) */ | ||
| #define ACK_SLOT_OFFSET 4 /* offset of slot in ACK entry */ | ||
| #define MIN_PAYLOAD_SIZE (MSD_HEADER_LEN + 5) /* MSD header (4B) + protocol version (1B) + protocl flags (1B), open_len (1B), ack_count(1B), rt_len(1B) */ |
Contributor
There was a problem hiding this comment.
the maximum line length is 100 chars (i.e. put the comment above and split it into multiple lines, if needed).
| static bool name_match_cb(struct bt_data *data, void *user_data) | ||
| { | ||
| bool *matched = user_data; | ||
| if (data->type == BT_DATA_NAME_COMPLETE || data->type == BT_DATA_NAME_SHORTENED) { |
Comment on lines
47
to
48
| const char *target = TARGET_NAME; | ||
| size_t target_len = strlen(target); |
| .num_subevents = 1, | ||
| }; | ||
|
|
||
| uint8_t desired_subevent_id = target_subevent; |
Contributor
There was a problem hiding this comment.
define variable at top of scope
| int err = bt_le_per_adv_sync_subevent(sync_handle, &sync_param); | ||
| if (err) { | ||
| if (++subevent_retry_tries <= 5U) { /* retry up to 5 times*/ | ||
| (void)k_work_reschedule(&retry_subevent_sync_work, K_MSEC(10)); |
| if (++subevent_retry_tries <= 5U) { /* retry up to 5 times*/ | ||
| (void)k_work_reschedule(&retry_subevent_sync_work, K_MSEC(10)); | ||
| } else { | ||
| printk("[SYNC] Failed to set subevents after %u tries (err %d)\n", |
Contributor
There was a problem hiding this comment.
use LOG_* for output (without \n)
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
Created new sample for showcasing how use of PAwR can give higher throughput in many-to-one communitcation than classical BLE connections. This was done to show customers an alternative way to set up communication with many devices when they got insufficient throughput Signed-off-by: Solveig Lunde <[email protected]> Signed-off-by: Eirin Berget <[email protected]>
eirget
force-pushed
the
throughput_many_to_one_sample
branch
from
cda6fca to
f2ea010
Compare
NordicBuilder
removed
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new sample for showcasing how use of PAwR can give higher throughput in many-to-one communitcation than classical BLE connections. This was done to show customers an alternative way to set up communication with many devices when they got insufficient throughput