Skip to content

Conversation

@gregersrygg
Copy link
Contributor

The documentation and kconfig options for PGPS needs to be updated to reflect whats currently supported by nRF Cloud.

Copilot AI review requested due to automatic review settings January 7, 2026 15:27
@gregersrygg gregersrygg requested review from a team as code owners January 7, 2026 15:27
@NordicBuilder NordicBuilder added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 7, 2026
@NordicBuilder NordicBuilder requested a review from a team January 7, 2026 15:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the P-GPS (Predicted GPS) documentation and configuration to reflect current nRF Cloud capabilities, specifically removing the unsupported 120-minute prediction period option and adjusting documentation accordingly.

Key changes:

  • Removes the 120-minute prediction period configuration option, leaving only 240-minute periods supported
  • Updates maximum prediction count from 84 to 42 (one week instead of two weeks)
  • Corrects a typo in the Kconfig help text

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
subsys/net/lib/nrf_cloud/common/src/nrf_cloud_pgps.c Removed conditional compilation for 120-minute prediction period, hardcoding to 240 minutes
subsys/net/lib/nrf_cloud/Kconfig.nrf_cloud_pgps Removed 120-minute prediction period choice, adjusted range limits for prediction counts, and fixed typo in help text
doc/nrf/libraries/networking/nrf_cloud_pgps.rst Updated documentation to reflect one-week (instead of two-week) prediction support and removed references to 120-minute periods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 7, 2026

CI Information

To view the history of this post, click the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 96f902b96357519c6a89657a7b2e5dc3a81968ef

more details

sdk-nrf:

PR head: 96f902b96357519c6a89657a7b2e5dc3a81968ef
merge base: 68440e95ec3d84de1861b9e3230424c364faea4f
target head (main): af6306bfbe1e731a4522fb2cb1197775e2baff65
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── nrf91
│  │  │  │  │  │ nrf91_features.rst
│  │  ├── glossary.rst
│  │  ├── libraries
│  │  │  ├── networking
│  │  │  │  │ nrf_cloud_pgps.rst
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  ├── Kconfig.nrf_cloud_pgps
│  │  │  │  ├── common
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ nrf_cloud_pgps.c

Outputs:

Toolchain

Version: f911d4f4e7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f911d4f4e7_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 382
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_lrcs_mosh
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_mosh
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_positioning
Disabled integration tests
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this need a changelog entry?

@gregersrygg
Copy link
Contributor Author

Would this need a changelog entry?

@peknis Yes, that's probably worth mentioning. I can add it.

@pascal-nordic
Copy link
Contributor

You would also need to update the nRF Cloud documentation, it mention the 2 weeks period:

https://docs.nordicsemi.com/bundle/nrf-cloud/page/LocationServices/Features.html

Copilot AI review requested due to automatic review settings January 8, 2026 09:57
@gregersrygg gregersrygg requested a review from a team as a code owner January 8, 2026 09:57
@NordicBuilder NordicBuilder removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 8, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gregersrygg
Copy link
Contributor Author

You would also need to update the nRF Cloud documentation, it mention the 2 weeks period:

https://docs.nordicsemi.com/bundle/nrf-cloud/page/LocationServices/Features.html

@pascal-nordic That text seems to be in a different repo. So won't be part of this PR, but I found some other places in this repo that mentioned "two weeks" that I'll update.

@gregersrygg gregersrygg requested review from a team as code owners January 8, 2026 13:49
@NordicBuilder NordicBuilder requested a review from a team January 8, 2026 13:50
@gregersrygg gregersrygg requested a review from divipillai January 8, 2026 13:50
@gregersrygg gregersrygg self-assigned this Jan 8, 2026
Predicted GPS (P-GPS) is a form of assistance that reduces the :term:`Time to First Fix (TTFF)`, the time needed by a GNSS module to estimate its position.
It is provided through :term:`nRF Cloud` services.
In P-GPS, nRF Cloud provides data containing information about the estimated orbits (`Ephemerides <Ephemeris_>`_) of the 32 GPS satellites for up to two weeks.
In P-GPS, nRF Cloud provides data containing information about the estimated orbits (`Ephemerides <Ephemeris_>`_) of the 32 GPS satellites for up to one week.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In P-GPS, nRF Cloud provides data containing information about the estimated orbits (`Ephemerides <Ephemeris_>`_) of the 32 GPS satellites for up to one week.
In P-GPS, nRF Cloud provides data containing information about the estimated orbits (`Ephemerides <Ephemeris_>`_) of the 32 GPS satellites.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we shouldn't mention the exact number of days/weeks here, but I think the suggested change is too vague, so it doesn't really separate P-GPS from A-GPS. I changed it to «multiple days into the future» like I've used several other places.

@pascal-nordic
Copy link
Contributor

nRF Cloud Docs updated: https://github.com/nRFCloud/nrfcloud-docs/pull/459

The nRF Cloud REST API only supports 1 week of predictions now.

Remove NRF_CLOUD_PGPS_PREDICTION_PERIOD choice because 240 is the only
valid value in nRF Cloud.

Update max value for NRF_CLOUD_PGPS_NUM_PREDICTIONS and
NRF_CLOUD_PGPS_REPLACEMENT_THRESHOLD according to what is supported by
nRF Cloud.

Add changelog entry for nrf_cloud_pgps library changes.

Signed-off-by: Gregers Gram Rygg <[email protected]>
Copilot AI review requested due to automatic review settings January 9, 2026 11:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nordicjm nordicjm merged commit 69b449d into nrfconnect:main Jan 9, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants