Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix broken module paths provided via environment on macOS #11468

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PatTheMav
Copy link
Member

Description

Fix macOS-specific paths added to list of module paths when custom environment variables are provided to OBS Studio at launch.

Motivation and Context

When custom module and module data paths are provided via environment variables, the module paths generated by current code will not be compatible with the plugin bundle structure used on macOS.

Using environment variables is a simple way to test plugins, as this allows OBS to discover them from alternative user-provided locations.

How Has This Been Tested?

Tested on macOS with plugins put into a custom location and provided the same directory as OBS_PLUGINS_PATH and OBS_PLUGINS_DATA_PATH via Xcode launch options.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

When custom module and module data paths are provided via environment
variables, the module paths generated by current code will not be
compatible with the plugin bundle structure used on macOS.

Using environment variables is a simple way to test plugins,
as this allows OBS to discover them from alternative user-provided
locations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue macOS Affects macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants