Small cleanups to ease upstreaming #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the `runtest` root alias into `testsuite` and `internaltests` Make `ci` point by default to `testsuite`
To avoid getting a different output in internal expect tests (due to the `debug mode` message), force `v=0` into `OCAMLRUNPARAM` (and default its value to `b,v=0`)
jmid
approved these changes
Sep 12, 2024
|
CI summary for cd5b374
Out of 45 workflows, 1 test failed with a false alarm |
|
Merging! |
|
CI summary for merge to
Out of 46 workflows 1 failed with a genuine error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a couple of small changes. In particular the main two commits are intended to make it a bit easier to upstream a workflow running the testsuite to the compiler:
testsuiteandinternaltestsaliasesThis will make it easier to run only the testsuite per se upstream, and to avoid the noise of the
Skipping ...messages.The other 3 commits are to use the new aliases in our CI, to let the
debug modemessage appear in debug runs and to remove an obsolete comment:testsuiteandinternaltestsaliases in CI