Cleanup OpamStd of duplicated functions that already exist in Stdlib #6442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
from
b38f27d to
c592209
Compare
kit-ty-kate
added
the
PR: QUEUED
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
2 times, most recently
from
20f6dce to
3be9b6e
Compare
kit-ty-kate
removed
the
PR: QUEUED
kit-ty-kate
commented
Mar 31, 2025
| | (k, v, comment) :: r -> | ||
| if OpamConsole.verbose () then | ||
| OpamStd.Option.iter (Printf.ksprintf output ": %s;\n") comment; | ||
| Stdlib.Option.iter (Printf.ksprintf output ": %s;\n") comment; |
There was a problem hiding this comment.
Side note for reviewers: explicit uses of Stdlib is required in opam-client and opam-solver because extlib (used via dose3) shadows the standard library module
kit-ty-kate
added a commit
to kit-ty-kate/opam-rt
that referenced
this pull request
Mar 31, 2025
kit-ty-kate
added
the
PR: QUEUED
|
Note to myself for whenever i rebase this: OpamStd.Set.map is also redundant |
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
from
3be9b6e to
549d609
Compare
kit-ty-kate
added
AREA: API
and removed
PR: QUEUED
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
from
549d609 to
d548c62
Compare
|
OCaml Benchmarks seems to show a 3 to 8% speedup |
rjbou
added
the
PR: QUEUED
rjbou
approved these changes
Aug 25, 2025
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
from
fef413e to
c591adf
Compare
kit-ty-kate
removed
the
PR: QUEUED
kit-ty-kate
added a commit
to ocaml-opam/opam-publish
that referenced
this pull request
Aug 27, 2025
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
from
c591adf to
bf9c1c9
Compare
kit-ty-kate
added
PRIORITY
PR: QUEUED
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
from
bf9c1c9 to
5e75ded
Compare
kit-ty-kate
added a commit
to ocaml-opam/opam-publish
that referenced
this pull request
Aug 28, 2025
This was referenced Aug 28, 2025
kit-ty-kate
removed
the
PR: QUEUED
…hat already exist in Stdlib.{Set,Map} and have the same behaviour
kit-ty-kate
force-pushed
the
upgrade-to-ocaml-4.08-stdlib
branch
from
5e75ded to
a5eec66
Compare
rjbou
approved these changes
Aug 28, 2025
kit-ty-kate
added a commit
to ocaml-opam/opam-publish
that referenced
this pull request
Aug 28, 2025
Apply API changes from ocaml/opam#6442
kit-ty-kate
added a commit
to ocaml-opam/opam-rt
that referenced
this pull request
Aug 28, 2025
Apply API changes from ocaml/opam#6442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queued on #6444Queued on #6394Queued on #6655Requires ocaml-opam/opam-rt#85
Requires ocaml-opam/opam-publish#173
See robur-coop/orb#22
See ocaml/odoc#1383
A little spring cleaning