[IMP] clickable cell: add tooltips on links#6497
Closed
Conversation
Collaborator
|
|
fdamhaut
force-pushed
the
master-spreadsheet-dashboard-add-tooltip-link-flda
branch
2 times, most recently
from
af0f826 to
d718fd0
Compare
hokolomopo
reviewed
May 28, 2025
Comment on lines
+8
to
+9
| title?: string; | ||
| titleCompute?: (position: CellPosition, getters: Getters) => string; |
Contributor
There was a problem hiding this comment.
probably better to change title instead, making it either ´string | () => string' or always a function, like we do in the menu items. Because what if both title and titleCompute are defined ?
fdamhaut
force-pushed
the
master-spreadsheet-dashboard-add-tooltip-link-flda
branch
2 times, most recently
from
c9714a0 to
0db2f67
Compare
pro-odoo
reviewed
Jun 23, 2025
Task: 4551511
rrahir
force-pushed
the
master-spreadsheet-dashboard-add-tooltip-link-flda
branch
from
0db2f67 to
46f0e04
Compare
Collaborator
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 24, 2025
closes #6497 Task: 4551511 Signed-off-by: Rémi Rahir (rar) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 4551511
review checklist