Skip to content

[IMP] clickable cell: add tooltips on links #6497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fdamhaut
Copy link
Contributor

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 4551511

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented May 26, 2025

Pull request status dashboard

@fdamhaut fdamhaut force-pushed the master-spreadsheet-dashboard-add-tooltip-link-flda branch from 79dca7c to af0f826 Compare May 26, 2025 13:38
@fdamhaut fdamhaut force-pushed the master-spreadsheet-dashboard-add-tooltip-link-flda branch from af0f826 to d718fd0 Compare May 26, 2025 13:49
Comment on lines 8 to +9
title?: string;
titleCompute?: (position: CellPosition, getters: Getters) => string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better to change title instead, making it either ´string | () => string' or always a function, like we do in the menu items. Because what if both title and titleCompute are defined ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants