[IMP] clickable cell: add tooltips on links

src/components/dashboard/clickable_cell_store.ts

@@ -72,12 +72,13 @@ export class ClickableCellsStore extends SpreadsheetStore {
       if (!item) {
         continue;
       }
+      const title = typeof item.title === "function" ? item.title(position, getters) : item.title;
       const zone = getters.expandZone(sheetId, positionToZone(position));
       cells.push({
         coordinates: getters.getVisibleRect(zone),
         position,
         action: item.execute,
-        title: item.title || "",
+        title: title || "",
       });
     }
     return cells;

src/registries/cell_clickable_registry.ts

@@ -1,11 +1,12 @@
 import { openLink } from "../helpers/links";
+import { _t } from "../translation";
 import { CellPosition, Getters, SpreadsheetChildEnv } from "../types";
 import { Registry } from "./registry";
 
 export interface CellClickableItem {
   condition: (position: CellPosition, getters: Getters) => boolean;
   execute: (position: CellPosition, env: SpreadsheetChildEnv, isMiddleClick?: boolean) => void;
-  title?: string;
+  title?: string | ((position: CellPosition, getters: Getters) => string);
   sequence: number;
 }
 
@@ -17,5 +18,14 @@ clickableCellRegistry.add("link", {
   },
   execute: (position: CellPosition, env: SpreadsheetChildEnv, isMiddleClick?: boolean) =>
     openLink(env.model.getters.getEvaluatedCell(position).link!, env, isMiddleClick),
+  title: (position, getters) => {
+    const link = getters.getEvaluatedCell(position).link;
+    if (!link) return "";
+    if (link.isExternal) {
+      return _t("Go to url: %(url)s", { url: link.url });
+    } else {
+      return _t("Go to %(label)s", { label: link.label });
+    }
+  },
   sequence: 5,
 });

tests/grid/dashboard_grid_component.test.ts

@@ -172,7 +172,7 @@ describe("Grid component in dashboard mode", () => {
     expect(fn).toHaveBeenCalledWith(true);
   });
 
-  test("Clickable cells actions can have a tooltip", async () => {
+  test("Clickable cells actions can have a generic tooltip", async () => {
     addToRegistry(clickableCellRegistry, "fake", {
       condition: () => true,
       execute: () => {},
@@ -185,4 +185,19 @@ describe("Grid component in dashboard mode", () => {
       "hello there"
     );
   });
+
+  test("Clickable cells actions can have a tooltip based on their position", async () => {
+    addToRegistry(clickableCellRegistry, "fake", {
+      condition: () => true,
+      execute: () => {},
+      title: (position, getters) => `hello ${getters.getCell(position)?.content}`,
+      sequence: 5,
+    });
+    setCellContent(model, "A1", "Magical Françoise");
+    model.updateMode("dashboard");
+    await nextTick();
+    expect(fixture.querySelector("div.o-dashboard-clickable-cell")?.getAttribute("title")).toBe(
+      "hello Magical Françoise"
+    );
+  });
 });