[v2.3.x] fabtests: add OOB finalize sync option #11669
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ft_finalize_ep is called in all tests and guarantees that no peer exits without confirming that the other peer is done as well. This is normally done with an in band send/recv with the FI_TRANSMIT_COMPLETE flag set which guarantees the send completion won't be generated until the message has completely be sent. This patch adds an out of band finalize option using the out of band socket if the user requested out of band syncs. Typically an in band finalize is sufficient but may be problematic with certain scenarios. For example, if the provider doesn't support FI_TRANSMIT_COMPLETE (rare) and for providers using an unreliable protocol underneath (rxd) where the last underlying acknowledgement may be dropped, which can result in one side exiting before the other waiting for an acknowldgement retry that will never come Signed-off-by: Alexia Ingerson <[email protected]> (cherry picked from commit c4b8492)
In the RDM case of the multi_ep test, the test calls fi_getinfo again for each EP in order to override the source address. The source address was getting set as the node for the new call but the FI_SOURCE flag was not set meaning the local source address was getting resolved into the dst_addr which was never used anyway. This removes the node parameter with the source address to let the provider set a source address for us. This also fixes an issue on cleanup if one of the calls to getinfo fails, the test would try to cleanup the resources and would segfault because the fi is NULL. Signed-off-by: Alexia Ingerson <[email protected]> (cherry picked from commit 1a749cb)
aingerson
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fixes for the multi_ep test.