Fix issue where adding or updating a case archive was returning an empty response body #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grapigeau
approved these changes
Jun 11, 2025
mlaszloffy
approved these changes
Jun 11, 2025
|
Looks like corresponding tests need to be fixed |
callunity
force-pushed
the
fix_return_value
branch
from
0b891ba to
30a03c4
Compare
…ng an empty response body
callunity
force-pushed
the
fix_return_value
branch
from
30a03c4 to
ebaedb5
Compare
Yes, fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: GP-4726
It looks like this had been partially broken for a while (case archive creation returned empty response body) which was causing issues with Shesmu, which was expecting the case in the response body, and then my last case archive PR broke it for case archive update as well.