[GLT-4378] allow custom deliverable types for signoffs #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callunity
reviewed
Jun 27, 2025
| deliverable | ||
| ); | ||
| if (!deliverable) { | ||
| return new ValidationError('Sign-off must be associated with a deliverable type'); |
There was a problem hiding this comment.
What do you think about "Sign-off must be associated with a deliverable" or "Sign-off must contain a deliverable" since the field is deliverable?
There was a problem hiding this comment.
The field is actually deliverableType
grapigeau
approved these changes
Jun 30, 2025
PrabhjotChopra
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://jira.oicr.on.ca/browse/GLT-4378