feat: rewrite of Device Service #20
okwasniewskici.yml
on: pull_request
build
1m 56s
lint
29s
test
59s
Annotations
2 errors and 16 warnings
|
test
testGetCustomCommands on 'My Mac - MiniSim (5083)' (0.413 seconds)
|
|
test
Process completed with exit code 65.
|
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint:
MiniSim/AppleScript Commands/NSScriptCommand+utils.swift#L23
Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
|
|
lint:
MiniSim/Views/About.swift#L61
Trailing Closure Violation: Trailing closure syntax should be used whenever possible (trailing_closure)
|
|
lint:
MiniSim/Menu.swift#L12
Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 252 lines (type_body_length)
|
|
lint:
MiniSim/Service/DeviceService.swift#L243
Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 11 (cyclomatic_complexity)
|
|
lint:
MiniSim/Service/DeviceService.swift#L393
Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 15 (cyclomatic_complexity)
|
|
lint:
MiniSim/Service/DeviceService.swift#L453
File Length Violation: File should contain 400 lines or less: currently contains 453 (file_length)
|
|
lint:
MiniSim/Service/DeviceService.swift#L393
Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 51 lines (function_body_length)
|
|
lint:
MiniSim/Service/CustomCommandService.swift#L3
Convenience Type Violation: Types used for hosting only static members should be implemented as a caseless enum to avoid instantiation (convenience_type)
|
|
lint:
MiniSim/Model/Platform.swift#L15
Todo Violation: TODOs should be resolved (Remove this type during migrat...) (todo)
|
|
lint:
MiniSimTests/DeviceParserTests.swift#L186
Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 69 lines (function_body_length)
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|