🎨 De-hypothesize regression test #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4616 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 732 732
Lines 24610 24610
Branches 3227 3227
=======================================
Hits 23793 23793
Misses 564 564
Partials 253 253 ☔ View full report in Codecov by Sentry. |
The original reason failures happened was because the form name was used to construct the file name of the PDF, which resulted in nested paths with forward slashes. The ambition with hypothesis was nice - whatever form name you specify should not result in broken file saving, but hypothesis comes up with some very exotic unicode characters that font libraries and/or weasyprint sometimes cannot handle. These edge cases are not worth fixing or mitigating with fancy input validating restricting the unicode range of valid characters, but we also do not want these flaky test failures. The test is rewritten without hypothesis to illustrate the original failure, preventing similar further regressions. If the edge cases do happen for real, we'll have a stakeholder funding the extra mitigations needed.
sergei-maertens
force-pushed
the
chore/test-cleanups-to-avoid-flakiness
branch
from
da55351
to
911ec28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original reason failures happened was because the form name was used to construct the file name of the PDF, which resulted in nested paths with forward slashes.
The ambition with hypothesis was nice - whatever form name you specify should not result in broken file saving, but hypothesis comes up with some very exotic unicode characters that font libraries and/or weasyprint sometimes cannot handle. These edge cases are not worth fixing or mitigating with fancy input validating restricting the unicode range of valid characters, but we also do not want these flaky test failures.
The test is rewritten without hypothesis to illustrate the original failure, preventing similar further regressions. If the edge cases do happen for real, we'll have a stakeholder funding the extra mitigations needed.